Re: TABLESAMPLE patch is really in pretty sad shape

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Petr Jelinek <petr(at)2ndquadrant(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: TABLESAMPLE patch is really in pretty sad shape
Date: 2015-09-19 01:36:02
Message-ID: 55FCBC02.4070309@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/23/15 6:39 PM, Tom Lane wrote:
> + 2202H E ERRCODE_INVALID_TABLESAMPLE_ARGUMENT invalid_tablesample_argument
> + 2202G E ERRCODE_INVALID_TABLESAMPLE_REPEAT invalid_tablesample_repeat

Where did you get these error codes from? The constants in the SQL
standard would map to

ERRCODE_INVALID_SAMPLE_SIZE
ERRCODE_INVALID_REPEAT_ARGUMENT_IN_A_SAMPLE_CLAUSE

Were you looking at a different standard, or did you intentionally
choose to rephrase?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2015-09-19 03:11:44 Re: Speed up Clog Access by increasing CLOG buffers
Previous Message Noah Misch 2015-09-19 01:10:37 Re: row_security GUC, BYPASSRLS