| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: creating extension including dependencies |
| Date: | 2015-09-07 19:28:07 |
| Message-ID: | 55EDE547.4000109@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-09-07 21:09, Alvaro Herrera wrote:
> Andres Freund wrote:
>> On 2015-09-07 20:56:50 +0200, Petr Jelinek wrote:
>>> Yes that sounds cleaner. Just as a side note, List is a Node and does have
>>> copy support (and we pass List as DefElem->arg from gram.y in several
>>> places).
>>
>> I know - but the list element in this case don't have copy support, no?
>> You seem to have put plain C strings in there, right?
>
> Seems slightly easier to use makeString(), no?
>
Yes, but I think Andres is correct when saying DefElem->arg is not
nicest place to put it to.
Looking at the code again, splitting the function is actually not that
easy since the cascaded extension creation has to execute all the same
code/checks as CreateExtension does; It might be better to just add the
parameter to the CreateExtension and call it with NIL value from utility.c.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2015-09-07 19:32:04 | Re: WIP: Access method extendability |
| Previous Message | Alvaro Herrera | 2015-09-07 19:27:19 | Re: PATCH: numeric timestamp in log_line_prefix |