| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: WIP: Rework access method interface |
| Date: | 2015-09-07 19:02:28 |
| Message-ID: | 55EDDF44.10408@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-09-07 20:56, Alexander Korotkov wrote:
> On Mon, Sep 7, 2015 at 9:17 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com
>
> However I don't like the naming differences between validate_opclass
> and amvalidate. If you expect that the current amvalidate will only
> be used for opclass validation then it should be renamed accordingly.
>
>
> I'm not yet sure if we need separate validation of opfamilies.
>
Well either the amvalidate or the validate_opclass should be renamed
IMHO, depending on which way the checking goes (one interface for
everything with generic name or multiple interfaces for multiple
validations).
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-09-07 19:09:27 | Re: creating extension including dependencies |
| Previous Message | Andres Freund | 2015-09-07 19:01:23 | Re: creating extension including dependencies |