| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, mail(at)bwe(dot)im, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, PostgreSQL Bugs List <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #12379: pgbench should hint to pgbench -i |
| Date: | 2015-08-22 13:28:56 |
| Message-ID: | 55D87918.6030805@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 07/18/2015 05:16 PM, Julien Rouhaud wrote:
> On 18/07/2015 13:49, Fabien COELHO wrote:
>>
>> Hello Julien,
>>
>>> Here's a v7 patch which display the hint only if SQLSTATE is
>>> ERRCODE_UNDEFINED_TABLE and use the message Tom suggested, as there
>>> wasn't any better suggestion or strong objection with it in the other
>>> thread.
>>
>> I'm wondering why you added the define. Isn't-there some convenient
>> include to get errcode definitions?
>
> IIRC correctly, you have to include postgres.h for that. I supposed it
> was better to define it than adding such an include, since it shouldn't
> change and it's already done like this in vacuumdb.c.
Ok, committed.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | av.kostromin | 2015-08-22 18:25:10 | BUG #13584: Upsert. The sequence value is increased. |
| Previous Message | Tom Lane | 2015-08-21 16:28:33 | Re: BUG #13579: Server crashes after executing plpythonu function |