| From: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, Noah Misch <noah(at)leadboat(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Test code is worth the space |
| Date: | 2015-08-17 18:58:23 |
| Message-ID: | 55D22ECF.40705@BlueTreble.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/15/15 4:45 AM, Petr Jelinek wrote:
> We could fix a) by adding ORDER BY to those queries but I don't see how
> to fix the rest easily or at all without sacrificing some test coverage.
Hopefully at some point we'll have test frameworks that don't depend on
capturing raw psql output, which presumably makes dealing with a lot of
this easier.
Maybe some of this could be handled by factoring BLKSZ into the queries...
A really crude solution would be to have expected output be BLKSZ
dependent where appropriate. No one will remember to test that by hand,
but if we have CI setup then maybe it's workable...
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Data in Trouble? Get it in Treble! http://BlueTreble.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-08-17 19:02:06 | Re: Configure with thread sanitizer fails the thread test |
| Previous Message | Peter Geoghegan | 2015-08-17 18:57:11 | Re: missing documentation for partial WAL files |