From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: TAP tests are badly named |
Date: | 2015-08-13 16:18:53 |
Message-ID: | 55CCC36D.4030701@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 08/13/2015 12:03 PM, Michael Paquier wrote:
> On Fri, Aug 14, 2015 at 12:17 AM, Andrew Dunstan wrote:
>> here's what I propose.
> This patch does not take into account that there may be other code
> paths than src/bin/ that may have TAP tests (see my pending patch to
> test pg_dump with extensions including dumpable relations for
> example). I guess that it is done on purpose, now what are we going to
> do about the following things:
> - for src/test/ssl, should we have a new target in vcregress? Like ssltest?
> - for the pending patch I just mentioned, what should we do then?
> Should we expect it to work under modulescheck?
Of course it takes it into account. What it does is let you add extra
checks easily. But I am not going to accept the divergence in
vcregress.pl from the way we run tests using the standard tools. Yes,
ssl tests should have a new target, as should any other new set of
tests. We don't have a single make target for tap tests and neither
should we in vcregress.pl.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2015-08-13 17:46:56 | pgsql: Re-add BRIN isolation test |
Previous Message | Michael Paquier | 2015-08-13 16:03:49 | Re: TAP tests are badly named |