| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Warnings around booleans |
| Date: | 2015-08-13 11:50:06 |
| Message-ID: | 55CC846E.6030001@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/13/2015 02:41 PM, Andres Freund wrote:
> On 2015-08-13 14:28:58 +0300, Heikki Linnakangas wrote:
>> On 08/12/2015 03:46 PM, Stephen Frost wrote:
>>> * Andres Freund (andres(at)anarazel(dot)de) wrote:
>>>> On 2015-08-12 08:16:09 -0400, Stephen Frost wrote:
>>>>>> 1) gin stores/queries some bools as GinTernaryValue.
>>>>>>
>>>>>> Part of this is easy to fix, just adjust GinScanKeyData->entryRes to
>>>>>> be a GinTernaryValue (it's actually is compared against
>>>>>> MAYBE).
>
> That bit looks sane to you? That appears to be an actual misdeclaration
> to me.
Yeah, changing entryRes to GinTernaryValue seems good to me.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kouhei Kaigai | 2015-08-13 11:56:14 | Re: [DESIGN] ParallelAppend |
| Previous Message | Andres Freund | 2015-08-13 11:41:54 | Re: Warnings around booleans |