| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: tap tests remove working directories |
| Date: | 2015-08-08 16:40:16 |
| Message-ID: | 55C630F0.5070606@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/08/2015 09:31 AM, Robert Haas wrote:
> On Fri, Aug 7, 2015 at 7:17 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> That certainly isn't what happens, and given the way this is done in
>> TestLib.pm, using the CLEANUP parameter of File::Temp's tempdir() function,
>> it's not clear how we could do that easily.
> <shot-in-the-dark>
>
> Set cleanup to false and manually remove the directory later in the
> code, so that stuff runs only if we haven't died sooner?
>
> </shot-in-the-dark>
>
Yeah, maybe. I'm thinking of trying to do it more globally, like in
src/Makefile.global.in. That way we wouldn't have to add new code to
every test file.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2015-08-08 16:47:28 | Test code is worth the space |
| Previous Message | Shay Rojansky | 2015-08-08 15:34:30 | Re: statement_timeout affects query results fetching? |