| From: | Joe Conway <joe(dot)conway(at)crunchydata(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: more RLS oversights |
| Date: | 2015-07-29 15:52:46 |
| Message-ID: | 55B8F6CE.4030302@crunchydata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/29/2015 02:41 AM, Dean Rasheed wrote:
> I don't think there is any point in adding the new function
> transformPolicyClause(), which is identical to transformWhereClause().
> You can just use transformWhereClause() with EXPR_KIND_POLICY. It's
> already used for lots of other expression kinds.
Yeah, I was debating that. Although I do think the name
transformWhereClause() is unfortunate. Maybe it ought to be renamed
transformBooleanExpr() or something similar?
> There are a couple of places in test_rls_hooks.c that also need updating.
Right -- thanks
> I think that check_agglevels_and_constraints() and
> transformWindowFuncCall() could be made to emit more targeted error
> messages for EXPR_KIND_POLICY, for example "aggregate functions are
> not allowed in policy USING and WITH CHECK expressions".
ok
Thanks for the review.
Joe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2015-07-29 15:56:36 | Re: dblink: add polymorphic functions. |
| Previous Message | Alvaro Herrera | 2015-07-29 15:47:51 | Re: upgrade failure from 9.5 to head |