From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, chenjq(dot)jy(at)fujitsu(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
Subject: | Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command |
Date: | 2021-08-18 13:49:48 |
Message-ID: | 55B64E31-A6E6-4805-9650-AE3A78A2DF34@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
> On 18 Aug 2021, at 15:46, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> On Wed, Aug 18, 2021 at 3:43 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>>>> On 18 Aug 2021, at 13:44, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>>>> I think this both of these things could be deleted and we could get rid of the --quiet option, to simplify all this.
>>
>>> It simplifies the pg_amcheck code a bit, but it at the same time complicates
>>> the tests as they are currently written. Not sure that we want to change that
>>> much as this point in the 14 cycle?
>>
>> It's going to become much harder to change pg_amcheck's user-visible
>> behavior once it's shipped in a release. Better to fix it now while
>> there are not backwards-compatibility concerns.
>
> +<several>. Let's just get it done now. I doubt many people have had
> the time to integrate it into their scripts and such yet, and since
> it's a beta...
Since there is consensus for removing --quiet, I’ll propose a patch in a bit
for removing it and fixing up the tests.
--
Daniel Gustafsson https://vmware.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Hybler | 2021-08-18 15:06:54 | PGSQL bug - "Column ??? is an identity column defined as GENERATED ALWAYS.", |
Previous Message | Magnus Hagander | 2021-08-18 13:46:20 | Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command |