| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(dot)dunstan(at)pgexperts(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: "make check" changes have caused buildfarm deterioration. |
| Date: | 2015-07-22 01:04:10 |
| Message-ID: | 55AEEC0A.3070607@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/21/15 10:00 AM, Tom Lane wrote:
> I agree; this change may have seemed like a good idea at the time, but
> it was not. Failures during "make check"'s install step are rare enough
> that you don't really need all that output in your face to help with the
> rare situation where it fails. And for the buildfarm's purposes, it is
> surely desirable to segregate that output from the actual check step.
It wasn't really an idea; it was just not necessary anymore. We can put
it [directing the make install output into a file] back if that's what
people prefer.
> A possible alternative is to run the "make install" sub-step with -s,
> but that could be objected to on the grounds that if it did fail, you'd
> have a hard time telling exactly which step failed.
I usually run the whole make check with -s.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-07-22 01:06:42 | Re: "make check" changes have caused buildfarm deterioration. |
| Previous Message | Jaimin Pan | 2015-07-22 00:53:53 | Re: [HACKERS] object_classes array is broken, again |