Re: PANIC in GIN code

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PANIC in GIN code
Date: 2015-06-30 10:49:07
Message-ID: 55927423.2000909@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/30/2015 02:18 AM, Jeff Janes wrote:
> On Mon, Jun 29, 2015 at 2:08 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
>> I just pushed a fix for this, but unfortunately it didn't make it
>> 9.5alpha1.
>
> Thanks. I think that that fixed it. It survived for over an hour this
> time.

Thanks. I grepped through all the other call sites of
XLogInitBufferForRedo() to look for similar bugs, and sure enough, there
was one more bug of the same sort, in B-tree page deletion. That one was
in 9.4 as well. Fixed that too, and added an assertion into
PageGetSpecialPointer() that would help to catch this sort of bugs
earlier in the future.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2015-06-30 12:23:05 Re: Dereferenced pointer in tablesample.c
Previous Message David Rowley 2015-06-30 10:37:57 Re: Refactor to split nodeAgg.c?