Re: pgbench - allow backslash-continuations in custom scripts

On 06/19/2015 02:51 PM, Tom Lane wrote:
> Josh Berkus <josh(at)agliodbs(dot)com> writes:
>> On 05/14/2015 12:10 PM, Fabien COELHO wrote:
>>> Add backslash continuations to pgbench custom scripts.
>
>> I don't personally agree. I believe that it it worth breaking backwards
>> compatibility to support line breaks in pgbench statements, and that if
>> we're not going to do that, supporting \ continuations is of little value.
>
> I tend to agree on that bottom line; having this be inconsistent with psql
> does not seem like a win.
>
>> I'm not clear on why we'd need a full SQL lexer.
>
> So you don't get fooled by semicolons embedded in string literals or
> comments.

I take it we ignore those now? I mean, personally, it wouldn't break
anything for me but since some other benhcmarks involve random text
generators ....

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com