| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Add a new GUC and a reloption to enable inserts in parallel-mode |
| Date: | 2021-03-22 14:33:22 |
| Message-ID: | 558385.1616423602@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I find this fairly ugly. If you can't make the cost of checking
> whether parallelism is safe low enough that you don't need a setting
> for this, then I think perhaps you shouldn't have the feature at all.
> In other words, I propose that you revert both this and 05c8482f7f and
> come back when you have a better design that doesn't introduce so much
> overhead.
I'm +1 on that idea for a completely independent reason: 05c8482f7f
is currently the easy winner for "scariest patch of the v14 cycle".
I don't have any faith in it, and so I'm very concerned that it went
in so late in the dev cycle. It'd be better to push some successor
design early in the v15 cycle, when we'll have more time to catch
problems.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-03-22 14:35:04 | pgsql: docs: Fix omissions related to configurable TOAST compression. |
| Previous Message | Robert Haas | 2021-03-22 13:53:53 | pgsql: More code cleanup for configurable TOAST compression. |