Re: Missed bet in toaster routines

Jan Wieck <JanWieck(at)Yahoo(dot)com> writes:
> Tom Lane wrote:
>> Wouldn't it be a win for heap_tuple_toast_attrs() to fall out quickly
>> if the tuple contains no varlena attributes?

> Why sure it would. That code is quite frequently called.

I take it back --- the short-circuit test already exists, but it's at
the call sites rather than in tuptoaster.c.

However, it looks like we can tighten the tests a bit. For instance
heap_delete invokes the toaster if HeapTupleHasExtended, whereas it
seems to me it'd be sufficient to check HasExternal --- we don't care
about deleting compressed-in-line stuff, do we?

regards, tom lane