| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, hlinnaka <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Date: | 2015-06-05 01:59:38 |
| Message-ID: | 5571028A.1070706@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 06/04/2015 09:23 AM, Amit Kapila wrote:
>
>
>
> Okay, as we both seem to agree that it can be mostly used in
> tablespace symlinks context, so I have changed the name to
> remove_tablespace_symlink() and moved the function to
> tablespace.c. S_ISLINK check is used for non-windows code,
> so not sure adding it here makes any real difference now that
> we have made it specific to tablespace and we might need to
> write small port specific code if we want to add S_ISLINK check.
>
Where is it used? I can't see it called at all in tablespace.c or xlog.c.
Perhaps I'm being overcautious, but here's more or less what I had in mind.
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| remove_only_symlinks_during_recovery_v3.patch | text/x-diff | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2015-06-05 03:35:07 | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Previous Message | Amit Kapila | 2015-06-05 01:02:55 | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-06-05 02:15:26 | Incorrect order of database-locking operations in InitPostgres() |
| Previous Message | Robert Haas | 2015-06-05 01:57:56 | Re: [idea] more aggressive join pushdown on postgres_fdw |