Re: [PATCH] Document that directly callable functions may use fn_extra

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Document that directly callable functions may use fn_extra
Date: 2015-05-29 15:21:02
Message-ID: 556883DE.5090508@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/28/15 10:15 PM, Craig Ringer wrote:
> I was a puzzled by src/backend/utils/fmgr/README and fmgr.h's
> descriptions of fcinfo->flinfo->fn_extra (FmgrInfo.fn_extra) as they
> seem to conflict with actual usage.
>
> The docs suggest that fl_extra is for the use of function call handlers,
> but in practice it's also used heavily by function implementations as a
> cache space.

The documentation could also be updated about this. It mentions using
fn_extra for PL handlers, gist functions, and set-returning functions,
but it doesn't say that you can use it any old function for anything you
want.

I'm not sure how up to date that README actually is. It looks more like
a historical document describing the original proposal.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-05-29 16:43:34 Re: [HACKERS] Re: 9.4.1 -> 9.4.2 problem: could not access status of transaction 1
Previous Message Stephen Frost 2015-05-29 14:30:26 Re: RFC: Remove contrib entirely