Re: Patch to improve a few appendStringInfo* calls

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to improve a few appendStringInfo* calls
Date: 2015-05-29 00:51:01
Message-ID: 5567B7F5.7050705@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/12/15 4:33 AM, David Rowley wrote:
> Shortly after I sent the previous patch I did a few more searches and
> also found some more things that are not quite right.
> Most of these are to use the binary append method when the length of the
> string is already known.

For these cases it might be better to invent additional functions such
as stringinfo_to_text() and appendStringInfoStringInfo() instead of
repeating the pattern of referring to data and length separately.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-05-29 00:59:11 Re: pg_upgrade resets timeline to 1
Previous Message Noah Misch 2015-05-29 00:43:42 Re: RFC: Non-user-resettable SET SESSION AUTHORISATION