| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, Ryan Pedela <rpedela(at)datalanche(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ilya Ashchepkov <koctep(at)gmail(dot)com> |
| Subject: | Re: jsonb concatenate operator's semantics seem questionable |
| Date: | 2015-05-22 18:59:18 |
| Message-ID: | 555F7C86.4070809@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05/22/2015 02:38 PM, Jim Nasby wrote:
> On 5/21/15 4:25 PM, Andrew Dunstan wrote:
>> Here is a patch that renames jsonb_replace to jsonb_set with a boolean
>> create_missing flag that defaults to false (should we default it to
>> true?). With the flag set it's more or less upsert for jsonb. Without,
>> it's just update.
>
> I think upsert is probably the more expected behavior.
>
> Though, I'm also wondering if we should allow for throwing an error if
> path doesn't already exist (it looks like if create_missing is false
> it silently does nothing right now?)
Yes, that's actually documented in the patch.
As for raising an error, in principle it's doable, but the code to
detect it might get messy. Also, I don't want a huge number of knobs. So
I'm excited about the idea.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-05-22 19:23:32 | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| Previous Message | Pavel Stehule | 2015-05-22 18:45:15 | Re: Change pg_cancel_*() to ignore current backend |