| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, fabriziomello(at)gmail(dot)com |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Change pg_cancel_*() to ignore current backend |
| Date: | 2015-05-20 11:41:58 |
| Message-ID: | 555C7306.6060506@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/20/15 1:40 AM, Jim Nasby wrote:
> On 5/19/15 9:19 PM, Fabrízio de Royes Mello wrote:
>> We could add a second parameter to the current functions:
>> allow_own_pid DEFAULT false. To me that seems better than an
>> entirely separate set of functions.
>>
>>
>> +1 to add a second parameter to current functions.
>
> Instead of allow_own_pid, I went with skip_own_pid. I have the function
> still returning true even when it skips it's own PID... that seems a bit
> weird, but I think it's better than returning false. Unless someone
> thinks it should return NULL, but I don't see that as any better either.
+1. I agree that cancelling/killing your own process should not be the
default behavior.
--
- David Steele
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jon Nelson | 2015-05-20 12:38:35 | Re: Change pg_cancel_*() to ignore current backend |
| Previous Message | Fabrízio de Royes Mello | 2015-05-20 11:06:22 | Re: Change pg_cancel_*() to ignore current backend |