| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Zhang Zq <zqzhangmail(at)163(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG in XLogRecordAssemble |
| Date: | 2015-05-04 18:04:05 |
| Message-ID: | 5547B495.7040607@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05/04/2015 07:04 PM, Zhang Zq wrote:
> hi,
> I found the code in 'backend/access/transam/xloginsert.c' as that:
> XLogRecordAssemble:
> if (prev_regbuf && RelFileNodeEquals(regbuf->rnode, prev_regbuf->rnode))
> {
> samerel = true;
> bkpb.fork_flags |= BKPBLOCK_SAME_REL;
> prev_regbuf = regbuf;
> }
> else
> samerel = false;
>
> There is the only place that prev_regbuf is assigned, so prev_regbuf will never be assigned.
> The patch will fix it, Thanks.
Thanks, good catch! Committed.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-05-04 18:23:16 | Re: initdb -S and tablespaces |
| Previous Message | Tom Lane | 2015-05-04 17:50:45 | Re: Unexpected speed PLAIN vs. MAIN |