Re: pg_basebackup, tablespace mapping and path canonicalization

From: Ian Barwick <ian(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup, tablespace mapping and path canonicalization
Date: 2015-04-29 00:35:26
Message-ID: 5540274E.8070702@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 29/04/15 09:12, Bruce Momjian wrote:
> On Fri, Feb 6, 2015 at 08:25:42AM -0500, Robert Haas wrote:
>> On Thu, Feb 5, 2015 at 10:21 PM, Ian Barwick <ian(at)2ndquadrant(dot)com> wrote:
>>> I stumbled on what appears to be inconsistent handling of double slashes
>>> in tablespace paths when using pg_basebackup with the -T/--tablespace-mapping
>>> option:
>>>
>>> ibarwick:postgresql (master)$ mkdir /tmp//foo-old
>> [...]
>>> The attached patch adds the missing canonicalization; I can't see any
>>> reason not to do this. Thoughts?
>>
>> Seems OK to me. Anyone think differently?
>
> Patch applied.

Thanks!

Regards

Ian Barwick

--
Ian Barwick http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-04-29 00:36:13 Re: pg_rewind test race condition..?
Previous Message Jim Nasby 2015-04-29 00:25:52 Re: Allow SQL/plpgsql functions to accept record