Re: getting confused parsing ACLITEMS...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: getting confused parsing ACLITEMS...
Date: 2003-08-09 15:00:41
Message-ID: 5534.1060441241@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
>> More to the point, this is highly incomplete... you did not teach the
>> adjacent getid routine about this, and there is code in (at least)
>> pg_dump.c that knows the quoting conventions used here.

> Hang on - those routines can parse the acls just fine? How? How do they
> handle usernames with equals signs in them (my major prob). How can it
> work at all?

IIRC, the present code assumes that usernames won't contain embedded
doublequotes. I did recently fix pg_dump to work in cases that it
wouldn't have handled before, including embedded equals. (BTW, my
mistake above: the pg_dump code is not in pg_dump.c, but in dumputils.c.
Look at copyAclUserName in particular.)

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2003-08-09 15:19:06 Re: Batch Operations
Previous Message Tom Lane 2003-08-09 14:55:43 Re: getting confused parsing ACLITEMS...