Re: bug w/ cursors and savepoints

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Neil Conway <neilc(at)samurai(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bug w/ cursors and savepoints
Date: 2005-01-25 18:29:47
Message-ID: 5533.1106677787@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> ! if (portal->status == PORTAL_ACTIVE)
> portal->status = PORTAL_FAILED;

> ! if (portal->status == PORTAL_ACTIVE || portal->status == PORTAL_READY)
> portal->status = PORTAL_FAILED;

I don't think you actually need that change, since you're going to
unconditionally close the portal below. The case for PORTAL_ACTIVE
is just there to dodge the sanity check in PortalDrop.

The routine's comments need a bit of work too. Otherwise it seems OK.
Neil or anyone else --- see an issue here?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2005-01-25 18:47:56 Re: Heads up: upcoming releases in all branches back to 7.2
Previous Message Alvaro Herrera 2005-01-25 18:23:15 Re: bug w/ cursors and savepoints