Re: pgsql: Error out in pg_rewind if lstat() fails.

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Error out in pg_rewind if lstat() fails.
Date: 2015-04-16 06:23:48
Message-ID: 552F5574.4030701@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 04/16/2015 04:17 AM, Michael Paquier wrote:
> On Thu, Apr 16, 2015 at 5:15 AM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>> Error out in pg_rewind if lstat() fails.
>>
>> A "file not found" is expected if the source server is running, so don't
>> complain about that. But any other error is definitely not expected.
>
> Nitpicking: strings of pg_fatal need to have a newline '\n' for readability.

Ah, good catch! Fixed.

- Heikki

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bernd Helmle 2015-04-16 14:44:39 Re: [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/
Previous Message Heikki Linnakangas 2015-04-16 06:23:28 pgsql: Add missing newlines to error messages.