| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/ |
| Date: | 2015-04-15 14:51:30 |
| Message-ID: | 552E7AF2.6050205@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | buildfarm-members pgsql-committers pgsql-hackers |
On 04/15/2015 08:31 AM, Michael Paquier wrote:
> On Wed, Apr 15, 2015 at 7:54 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> On 4/14/15 8:32 PM, Peter Eisentraut wrote:
>>> Move pg_upgrade from contrib/ to src/bin/
>> Oh dear. It appears the buildfarm client code needs to be updated to
>> support this. How do we do this? (I guess the critters that are still
>> green are not running this test.)
> Argh..
>
> Looking at the buildfarm client code
> (https://github.com/PGBuildFarm/client-code) we are going to need to
> make the logic of TestUpgrade.pm aware that pg_upgrade is now in
> src/bin and not in contrib. A simple idea would be to use a Find to
> guess where pg_upgrade oath is located and then use the path found
> instead of hardcoding contrib/.
>
>
I'm testing a fix. I just happened to check the status this morning. It
would have been nice to have had a heads up. The Find idea is cute, I
might have used it if I hadn't already coded a fix.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2015-04-15 15:11:02 | Re: [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/ |
| Previous Message | Michael Paquier | 2015-04-15 12:31:42 | Re: [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/ |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2015-04-15 15:11:02 | Re: [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/ |
| Previous Message | Heikki Linnakangas | 2015-04-15 14:23:19 | pgsql: Fix logic to skip checkpoint if no records have been inserted. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2015-04-15 14:58:54 | Re: INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0 |
| Previous Message | Alvaro Herrera | 2015-04-15 14:44:21 | Re: Turning off HOT/Cleanup sometimes |