From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Subject: | Re: improving speed of make check-world |
Date: | 2015-04-10 19:35:28 |
Message-ID: | 55282600.9030804@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 3/9/15 2:51 AM, Michael Paquier wrote:
> On Sun, Mar 8, 2015 at 10:46 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> Speaking of which, attached is a patch rewritten in-line with those
>> comments, simplifying a bit the whole at the same time. Note this
>> patch changes ecpgcheck as it should be patched, but as ecpgcheck test
>> is broken even on HEAD, I'll raise a separate thread about that with a
>> proper fix (for example bowerbird skips this test).
>
> Correction: HEAD is fine, but previous patch was broken because it
> tried to use --top-builddir. Also for ecpgcheck it looks that tricking
> PATH is needed to avoid dll loading errors related to libecpg.dll and
> libecpg_compat.dll. Updated patch is attached.
To clarify: Are you of the opinion that your patch (on top of my base
patch) is sufficient to make all of this work on Windows?
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2015-04-10 19:57:58 | Re: TABLESAMPLE patch |
Previous Message | Peter Eisentraut | 2015-04-10 19:26:35 | Re: TABLESAMPLE patch |