| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tv(at)fuzzy(dot)cz> |
| Subject: | Re: TABLESAMPLE patch |
| Date: | 2015-04-06 12:30:24 |
| Message-ID: | 55227C60.2040908@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06/04/15 11:02, Simon Riggs wrote:
> On 2 April 2015 at 17:36, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>
>> so here is version 11.
>
> Looks great.
>
> Comment on docs:
>
> The SELECT docs refer only to SYSTEM and BERNOULLI. It doesn't mention
> that if other methods are available they could be used also. The
> phrasing was "sampling method can be one of <list>."
>
Will reword.
> Are we ready for a final detailed review and commit?
>
I plan to send v12 in the evening with some additional changes that came
up from Amit's comments + some improvements to error reporting. I think
it will be ready then.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sawada Masahiko | 2015-04-06 12:40:34 | Re: Auditing extension for PostgreSQL (Take 2) |
| Previous Message | Petr Jelinek | 2015-04-06 12:26:22 | Re: TABLESAMPLE patch |