Re: pgsql: Add stats for min, max, mean, stddev times to pg_stat_statements

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add stats for min, max, mean, stddev times to pg_stat_statements
Date: 2015-03-27 22:26:58
Message-ID: 5515D932.8020305@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 03/27/2015 05:53 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Add stats for min, max, mean, stddev times to pg_stat_statements.
> The buildfarm is quite unhappy with this patch. Kinda looks like
> it was never tested on 32-bit machines.
>
>

I have committed a fix which is turning the buildfarm back to green.

However, it is moaning about the code in the sqrtd() function. I'm
wondering if we shouldn't just rip that out and use the library sqrt()
function. It's not called for every statement processed, only each time
the function is called (for each row).

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Petr Jelinek 2015-03-27 23:07:18 Re: pgsql: Add stats for min, max, mean, stddev times to pg_stat_statements
Previous Message Tom Lane 2015-03-27 21:53:21 Re: pgsql: Add stats for min, max, mean, stddev times to pg_stat_statements