| From: | Julien Tachoires <julmon(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se>, Alex Shulgin <ash(at)commandprompt(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch : Allow toast tables to be moved to a different tablespace |
| Date: | 2015-03-21 12:19:37 |
| Message-ID: | 550D61D9.9060602@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20/03/2015 00:33, Andreas Karlsson wrote:
> On 03/19/2015 04:55 PM, Julien Tachoires wrote:
>> On 18/03/2015 19:54, Andreas Karlsson wrote:
>>> Looks good but I think one minor improvement could be to set the table
>>> space of the toast entires to the same as the tablespace of the table to
>>> reduce the amount of "SET default_tablespace". What do you think?
>>
>> Yes, you're right, some useless "SET default_tablespace" were added for
>> each ALTER TABLE SET TOAST TABLESPACE statement. It's now fixed with
>> this new patch. Thanks.
>
> I am confused by your fix. Wouldn't cleaner fix be to use
> tbinfo->reltablespace rather than tbinfo->reltoasttablespace when
> calling ArchiveEntry()?
Yes, doing this that way is cleaner. Here is a new version including
your fix. Thanks.
--
Julien
| Attachment | Content-Type | Size |
|---|---|---|
| set_toast_tablespace_v0.17.patch.gz | application/gzip | 13.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-03-21 12:20:03 | Re: printing table in asciidoc with psql |
| Previous Message | Michael Paquier | 2015-03-21 11:13:00 | Re: GIN code managing entry insertion not able to differentiate fresh and old indexes |