| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Julien Tachoires <julmon(at)gmail(dot)com>, Alex Shulgin <ash(at)commandprompt(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch : Allow toast tables to be moved to a different tablespace |
| Date: | 2015-03-19 23:33:18 |
| Message-ID: | 550B5CBE.3020601@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/19/2015 04:55 PM, Julien Tachoires wrote:
> On 18/03/2015 19:54, Andreas Karlsson wrote:
>> Looks good but I think one minor improvement could be to set the table
>> space of the toast entires to the same as the tablespace of the table to
>> reduce the amount of "SET default_tablespace". What do you think?
>
> Yes, you're right, some useless "SET default_tablespace" were added for
> each ALTER TABLE SET TOAST TABLESPACE statement. It's now fixed with
> this new patch. Thanks.
I am confused by your fix. Wouldn't cleaner fix be to use
tbinfo->reltablespace rather than tbinfo->reltoasttablespace when
calling ArchiveEntry()?
I tried the attached path and it seemed to work just fine.
--
Andreas Karlsson
| Attachment | Content-Type | Size |
|---|---|---|
| set_toast_tablespace_v0.15-fix.patch | text/x-patch | 587 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2015-03-19 23:49:07 | Re: Using 128-bit integers for sum, avg and statistics aggregates |
| Previous Message | Tom Lane | 2015-03-19 23:27:16 | Re: [PATCH] two-arg current_setting() with fallback |