| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cleaning up perl code |
| Date: | 2024-07-02 15:11:22 |
| Message-ID: | 54d72e0f-9bb8-48d8-a31a-04401d506b07@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-07-02 Tu 8:55 AM, Dagfinn Ilmari Mannsåker wrote:
> Relatedly, I also had a look at prohibiting unused regex captures
> (RegularExpressions::ProhibitUnusedCapture), which found a few real
> cases, but also lots of false positives in Catalog.pm, because it
> doesn't understand that %+ uses all named captures, so I won't propose a
> patch for that until that's fixed upstream
> (https://github.com/Perl-Critic/Perl-Critic/pull/1065)
>
We could mark Catalog.pm with a "## no critic (ProhibitUnusedCapture)"
and then use the test elsewhere.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2024-07-02 15:11:52 | Re: Parallel CREATE INDEX for GIN indexes |
| Previous Message | Heikki Linnakangas | 2024-07-02 14:57:27 | Re: On disable_cost |