| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Arne Scheffer <arne(dot)scheffer(at)uni-muenster(dot)de>, David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add min and max execute statement time in pg_stat_statement |
| Date: | 2015-02-21 21:09:02 |
| Message-ID: | 54E8F3EE.6050403@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02/16/2015 09:05 PM, Petr Jelinek wrote:
> On 17/02/15 02:57, Andrew Dunstan wrote:
>>
>> On 02/16/2015 08:48 PM, Petr Jelinek wrote:
>>> On 17/02/15 01:57, Peter Geoghegan wrote:
>>>> On Mon, Feb 16, 2015 at 4:44 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com>
>>>> wrote:
>>>>> We definitely want this feature, I wished to have this info many
>>>>> times.
>>>>
>>>> I would still like to see a benchmark.
>>>>
>>>>
>>>
>>> Average of 3 runs of read-only pgbench on my system all with
>>> pg_stat_statement activated:
>>> HEAD: 20631
>>> SQRT: 20533
>>> SQRTD: 20592
>>>
>>>
>>
>>
>> So using sqrtd the cost is 0.18%. I think that's acceptable.
>>
>
> I think so too.
>
> I found one more issue with the 1.2--1.3 upgrade script, the DROP
> FUNCTION pg_stat_statements(); should be DROP FUNCTION
> pg_stat_statements(bool); since in 1.2 the function identity has changed.
>
>
I think all the outstanding issues are fixed in this patch.
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| pg_stat_statements-extrastats2.patch | text/x-patch | 13.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-02-21 21:10:34 | Re: NOT NULL markings for BKI columns |
| Previous Message | Andres Freund | 2015-02-21 21:08:25 | Re: Expanding the use of FLEXIBLE_ARRAY_MEMBER for declarations like foo[1] |