| From: | Oskari Saarenmaa <os(at)ohmu(dot)fi> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: __attribute__ for non-gcc compilers |
| Date: | 2015-02-17 13:41:45 |
| Message-ID: | 54E34519.2010803@ohmu.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
15.01.2015, 21:58, Robert Haas kirjoitti:
> On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> I think I'd for now simply not define pg_attribute_aligned() on
>> platforms where it's not supported, instead of defining it empty. If we
>> need a softer variant we can name it pg_attribute_aligned_if_possible or
>> something.
>>
>> Sounds sane?
>
> Yes, that sounds like a much better plan.
Attached an updated patch rebased on today's git master that never
defines aligned or packed empty.
This is also included in the current commitfest,
https://commitfest.postgresql.org/4/115/
/ Oskari
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-aligned-attribute-for-Sun-CC-and-use-custom-macr.patch | text/x-patch | 54.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-02-17 13:44:47 | Re: Bug in pg_dump |
| Previous Message | Tim Kane | 2015-02-17 13:22:15 | Re: postgres_fdw foreign keys with default sequence |