Re: pg_regress writes into source tree

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_regress writes into source tree
Date: 2015-02-13 21:24:48
Message-ID: 54DE6BA0.30408@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 12/18/2014 06:05 PM, Andrew Dunstan wrote:
>
> On 12/18/2014 03:02 AM, Michael Paquier wrote:
>> On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera
>> <alvherre(at)2ndquadrant(dot)com> wrote:
>>
>>> Another thing in that patch was that I had to add the sql/ directory to
>>> the source tree, but other than that .gitignore file it was empty.
>>> Maybe pg_regress should create the sql/ directory in the build dir
>>> if it
>>> doesn't exist. This is only a problem if a pg_regress suite only runs
>>> stuff from input/, because otherwise the sql/ dir already exists in the
>>> source.
>> +1 for having pg_regress create the sql/ directory when it does not
>> exist. Current behavior is annoying when modules having only tests in
>> input/...
>
>
>
> That seems like a separate issue. I think Peter should commit his
> patch and backpatch it immediately, and we can deal with the missing
> sql directory when someone sends in a patch.

What's happened on this?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mike Blackwell 2015-02-13 21:27:02 Re: RangeType internal use
Previous Message Jim Nasby 2015-02-13 21:13:11 Re: RangeType internal use