Re: Re: [COMMITTERS] pgsql: Another attempt at fixing Windows Norwegian locale.

On 01/31/2015 09:52 PM, Tom Lane wrote:
> Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
>> On 01/16/2015 07:05 PM, Heikki Linnakangas wrote:
>>> On 01/16/2015 04:17 PM, Tom Lane wrote:
>>>> What instructions do you have in mind to give?
>
>> Ok, I have created a wiki page for these instructions:
>
>> http://wiki.postgresql.org/wiki/Changes_To_Norwegian_Locale
>
>> They can be moved to the release notes, or we can just add a note there
>> with a link to the wiki page. I think the latter would be better.
>> Suggested reference in the release notes:
>
>> Migration to Version X
>
>> If you are a Windows user, using the "Norwegian (Bokmål)" locale, manual
>> action is needed after the upgrade, to replace the "Norwegian
>> (Bokmål)_Norway" locale names stored in system catalogs with its
>> pure-ASCII alias, "Norwegian_Norway". More information is available at
>> http://wiki.postgresql.org/wiki/Changes_To_Norwegian_Locale
>
> I've looked at this issue a bit now. I'm good with using essentially this
> text in the release notes, but I think the instructions are one brick shy
> of a load. Specifically, you claimed in the second commit that we'd not
> made any releases using "norwegian-bokmal", but that's utterly wrong:
> 9.4.0 uses that spelling.

Oops, I didn't realize that.

> What advice do we need to give 9.4 users?

I just downloaded the 9.4 EDB Windows installer and tried installing it.
initdb fails with the same error that I got after upgrading to more
recent MSVC version. "select version()" on the EDB binaries says:

version
-------------------------------------------------------------
PostgreSQL 9.4.0, compiled by Visual C++ build 1800, 64-bit
(1 row)

So there shouldn't be any existing Windows 9.4 installations that need
manual fixing, because the current binaries will just fail.

If there are any Norwegian users that have built Windows binaries
themselves, though, using an older MSVC version, then they would need to
follow the same manual fix-up steps to replace the "norwegian-bokmal"
locale names in pg_database with "Norwegian_Norway". Until they do,
CREATE DATABASE won't work (except with template=template0).

I suggest that we simply remove the notice about running the manual
steps from the 9.4.1 release notes.

- Heikki