Re: Small doc patch about pg_service.conf

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, David Fetter <david(at)fetter(dot)org>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small doc patch about pg_service.conf
Date: 2015-02-01 04:15:36
Message-ID: 54CDA868.9070704@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/3/15 7:56 PM, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
>> On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote:
>>> The directory libpq consults is `pg_config --sysconfdir`
>
>> I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which adjusts
>> to post-installation moves of the installation tree. parseServiceInfo() uses
>> the build-time SYSCONFDIR directly.
>
> Ugh. That makes things messy. Still, we're probably better off
> recommending `pg_config --sysconfdir` than anything else. I doubt
> that the theoretical ability to do a post-installation move is used
> much, and it's certainly not used by people using a prepackaged build.
> So the recommendation would only be wrong for someone who had done such
> a move manually, and they'd probably know what to do anyway.

At least writing `pg_config --sysconfdir` indicates that it's in an
installation-specific location, whereas hardcoding /etc will create
confusion when it's not actually there. (Incidentally, we use
/usr/local/pgsql/etc elsewhere in the documentation as a sample location.)

I propose the attached patch.

Attachment Content-Type Size
patch text/plain 728 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-02-01 07:38:24 Re: POLA violation with \c service=
Previous Message Tom Lane 2015-02-01 03:16:29 Re: Draft release notes up for review