| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PQgetssl() and alternative SSL implementations |
| Date: | 2015-01-28 17:18:53 |
| Message-ID: | 54C919FD.1000809@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/28/2015 06:58 PM, Stephen Frost wrote:
>> >Although I think "OpenSSL SSL" is a little bit duplicatively
>> >redundant. Why not just "OpenSSL"?
> I wondered also, but figured it was probably because it's OpenSSL's
> "ssl" structure, which then made sense.
Right, that was the idea. I wanted it to include the word "OpenSSL", to
make it clear in the callers that it's specific to OpenSSL. And SSL,
because that's the name of the struct. I agree it looks silly, though.
One idea is to have two separate arguments: the implementation name, and
the struct name. PQgetSSLstruct(&ssl, "OpenSSL", "SSL") would look less
silly.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2015-01-28 17:30:17 | Re: PQgetssl() and alternative SSL implementations |
| Previous Message | Andrew Dunstan | 2015-01-28 17:18:10 | Re: jsonb, unicode escapes and escaped backslashes |