Re: Request for review of new redis-fdw module

Please use this http://www.postgresql.org/community/lists/subscribe/ link.

On 28.01.2015 12:01, Quirin Hamp wrote:
> Please unsubscribe me from mailing list. Thank you!
>
> Bien cordialement, / Mit freundlichen Grüßen / Yours sincerely,
>
> Quirin HAMP
> _____________________________
> Viessmann Faulquemont S.A.S
> Responsable développement systèmes thermiques
> Avenue André GOUY
> F 57380 Faulquemont
>
> Tel.: +33 (0)3.87.90.64.12
> Mob.: +33 (0)6.88.54.57.08
> e-mail: HamQ(at)viessmann(dot)com
> web: www.viessmann.fr
>
>
>
> Von: Leon Dang <ldang(at)nahannisys(dot)com>
> An: pgsql-general(at)postgresql(dot)org
> Datum: 28.01.2015 09:25
> Betreff: Re: [GENERAL] Request for review of new redis-fdw module
> Gesendet von: pgsql-general-owner(at)postgresql(dot)org
> ------------------------------------------------------------------------
>
>
>
> The code has been posted to _https://github.com/nahanni/rw_redis_fdw_
>
> Anyone interested can test it out or review it.
>
> cheers
> Leon
>
>
>
> Leon Dang wrote on 01/24/2015 04:17 PM:
> Hi
>
> I've implemented a completely new Redis FDW module which has little to
> do with _github.com/pg-redis-fdw/redis_fdw_
> <http://github.com/pg-redis-fdw/redis_fdw>; although I did take some
> inspiration from in on how the tables were to be designed but most I
> got from looking at the oracle-fdw.
>
> My redis-fdw implementation supports read and write to the Redis
> backend, so you can do insert, update, and delete. e.g. you can define
> a hash table as:
>
> table rhash (
> key text,
> field text,
> value test,
> expiry int
> ) server redserver options(tabletype 'hash');
>
> and do:
> select * from rhash where key = 'foo' and field = 'bar';
> update rhash set value = 'bahbah' where key = 'foo' and field = 'bar';
> delete from rhash where key = 'foo' and field = 'bar';
>
> I need someone experienced with postgresql's internals for FDWs to
> review my code and let me know if I've done something wrong or where I
> can optimize it a little more. Once it has been reviewed, I'll post it
> up and announce it on my github account for public consumption. But
> for now I want to make sure that the code is correct.
>
> There are some functions (Explain* and costs) which I know I haven't
> implemented properly so assistance with that is also appreciated.
>
> Please email me if you can assist with reviewing.
>
> thanks
> Leon
>
>
> ------------------------------------------------------------------------
>
>
>
> *Viessmann - climate of innovation <http://www.viessmann.fr>*
>
> *Viessmann Faulquemont SAS
> *Avenue André Gouy
> 57380 FAULQUEMONT
> www.viessmann.fr
>