Re: Suppressing elog.c context messages (was Re: Wait free LW_SHARED acquisition)

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Suppressing elog.c context messages (was Re: Wait free LW_SHARED acquisition)
Date: 2015-01-27 00:30:13
Message-ID: 54C6DC15.3080305@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/23/14 11:41 AM, Andres Freund wrote:
>>> > >I think it'd generally be useful to have something like errhidecontext()
>>> > >akin to errhidestatement() to avoid things like the above.
>>> > >
>> >
>> >Under this proposal, do you want to suppress the context/statement
>> >unconditionally or via some hook/variable, because it might be useful to
>> >print the contexts/statements in certain cases where there is complex
>> >application and we don't know which part of application code causes
>> >problem.
> I'm proposing to do model it after errhidestatement(). I.e. add
> errhidecontext().
>
> I've attached what I was tinkering with when I wrote this message.
>
>>> > >The usecases wher eI see this as being useful is high volume debug
>>> > >logging, not normal messages...
>>> > >
>> >
>> >I think usecase is valid, it is really difficult to dig such a log
>> >especially when statement size is big.
> Right, that was what triggered to look me into it. I'd cases where the
> same context was printed thousands of times.

In case anyone picks this up... this problem exists in other places too, such as RAISE DEBUG in plpgsql. I think it'd be useful to have clien_min_context and log_min_context that operate akin to *_min_messages but control context output.
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-01-27 00:32:49 Re: Suppressing elog.c context messages (was Re: Wait free LW_SHARED acquisition)
Previous Message Petr Jelinek 2015-01-27 00:25:26 Re: Re: Abbreviated keys for Numeric