| From: | Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in pg_dump |
| Date: | 2015-01-20 11:06:51 |
| Message-ID: | 54BE36CB.5060800@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le 19/01/2015 14:41, Robert Haas a écrit :
> On Thu, Jan 15, 2015 at 6:26 AM, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> wrote:
>> I attach a patch that solves the issue in pg_dump, let me know if it might
>> be included in Commit Fest or if the three other solutions are a better
>> choice.
> I think a fix in pg_dump is appropriate, so I'd encourage you to add
> this to the next CommitFest.
>
Ok, thanks Robert. The patch have been added to next CommitFest under
the Bug Fixes section.
I've also made some review of the patch and more test. I've rewritten
some comments and added a test when TableInfo is NULL to avoid potential
pg_dump crash.
New patch attached: pg_dump.c-extension-FK-v2.patch
Regards
--
Gilles Darold
Consultant PostgreSQL
http://dalibo.com - http://dalibo.org
| Attachment | Content-Type | Size |
|---|---|---|
| pg_dump.c-extension-FK-v2.patch | text/x-diff | 6.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ali Akbar | 2015-01-20 11:17:05 | Re: PATCH: decreasing memory needlessly consumed by array_agg |
| Previous Message | Andrew Gierth | 2015-01-20 09:58:55 | Re: New CF app: changing email sender |