Re: pgsql: Remove USE_VPATH make variable from PGXS

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove USE_VPATH make variable from PGXS
Date: 2015-01-17 16:47:32
Message-ID: 54BA9224.4020309@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 1/17/15 11:21 AM, Andres Freund wrote:
> Him
>
> On 2014-12-04 16:35:27 +0000, Peter Eisentraut wrote:
>> Remove USE_VPATH make variable from PGXS
>>
>> The user can just set VPATH directly. There is no need to invent
>> another variable.
>
> I'm at a bit of loss why this was committed to 9.4 after rc1. This very
> much can (and has) broken external software.

What did it break?

AFAICT, this just reverted an unnecessary "feature" (USE_VPATH) that
shadowed an existing and perfectly working feature (using VPATH directly).

I agree the timing was unfortunate.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-01-17 16:58:54 Re: pgsql: Remove USE_VPATH make variable from PGXS
Previous Message Andres Freund 2015-01-17 16:21:42 Re: pgsql: Remove USE_VPATH make variable from PGXS