[PATCH] server_version_num should be GUC_REPORT

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: [PATCH] server_version_num should be GUC_REPORT
Date: 2015-01-09 06:29:43
Message-ID: 54AF7557.9090905@2ndquadrant.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all

While looking into client code that relies on parsing server_version
instead of checking server_version_num, I was surprised to discover that
server_version_num isn't sent to the client by the server as part of the
standard set of parameters reported post-auth.

The docs reflect this:

http://www.postgresql.org/docs/current/static/protocol-flow.html#PROTOCOL-ASYNC

The attached patch marks server_version_num GUC_REPORT and documents
that it's reported to the client automatically.

(See mention here:
https://github.com/impossibl/pgjdbc-ng/commit/40b6dc658a9b38725be220e2fa653a5a8a0cbae4#commitcomment-8427979)

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Send-server_version_num-to-client-on-start.patch text/x-patch 2.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-01-09 06:30:15 Re: orangutan seizes up during isolation-check
Previous Message Ashutosh Bapat 2015-01-09 06:27:46 Re: Transactions involving multiple postgres foreign servers