From: | Mark Cave-Ayland <mark(dot)cave-ayland(at)ilande(dot)co(dot)uk> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: Commitfest problems |
Date: | 2014-12-15 18:20:49 |
Message-ID: | 548F2681.3030809@ilande.co.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 15/12/14 16:28, Andres Freund wrote:
> I don't believe this really is a question of the type of project. I
> think it's more that especially the kernel has had to deal with similar
> problems at a much larger scale. And the granular approach somewhat
> works for them.
Correct. My argument was that dividing patches into smaller, more
reviewable chunks lessens the barrier for reviewers since many people
can review the individual patches as appropriate to their area of
expertise.
The benefits of this are that the many parts of the patchset get
reviewed early by a number of people, which reduces the workload on the
core developers as they only need to focus on a small number of
individual patches. Hence patches get reworked and merged much more
quickly in this way.
This is in contrast to the commitfest system where a single patch is i)
often held until the next commitfest (where bitrot often sets in) and
ii) requires the reviewer to have good knowledge all of the areas
covered by the patch in order to give a meaningful review, which
significantly reduces the pool of available reviewers.
ATB,
Mark.
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2014-12-15 18:32:32 | Re: Commit fest 2014-12, let's begin! |
Previous Message | Tom Lane | 2014-12-15 17:59:05 | Re: [Bug] Inconsistent result for inheritance and FOR UPDATE. |