| From: | Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andrew Sackville-West <awest(at)janrain(dot)com>, pgsql-bugs(at)postgresql(dot)org, Paulo Tanimoto <paulo(at)janrain(dot)com> |
| Subject: | Re: regression, deadlock in high frequency single-row UPDATE |
| Date: | 2014-12-14 02:22:01 |
| Message-ID: | 548CF449.9080402@catalyst.net.nz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 13/12/14 10:57, Alvaro Herrera wrote:
> Alvaro Herrera wrote:
>> Alvaro Herrera wrote:
>>
>>> I'm going to experiment with that idea and see if it leads to a
>>> solution. I tried the other idea yesterday (to keep the HW tuple lock
>>> we acquire in heap_lock_tuple until heap_update is done) but aside from
>>> being very complicated and bug-prone, it doesn't solve the problem
>>> anyway.
>>
>> Here's a preliminary patch.
>
> Here's a finished version of this patch, which I messed a bit with and
> so needs some extra testing. I want to push this shortly and backpatch
> to 9.4 and 9.3. I don't want to disrupt the 9.4.0 release next week,
> but it'd be nice not to ship it with this bug.
>
This patch seems good too. I'm possibly seeing it performing slightly
slower than the previous patch (approx 68 tps vs 63 on average -
completely untuned 9.5 running on a single SATA drive, but that could
just be natural variation/noise).
Regards
Mark
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Kirkwood | 2014-12-14 02:24:47 | Re: regression, deadlock in high frequency single-row UPDATE |
| Previous Message | jonlachlan | 2014-12-13 22:11:34 | BUG #12228: Primary use-case of PERCENT_RANK not supported |