| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Hendrik Grewe <Hendrik(dot)Grewe(at)tu-dortmund(dot)de>, <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #11949: pg_basebackup creates defective tar file |
| Date: | 2014-12-05 11:56:43 |
| Message-ID: | 54819D7B.4020501@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 12/04/2014 10:24 AM, Heikki Linnakangas wrote:
> The "too many bits in the mode field" problem seems to be that we store
> the file type bits that stat(2) returns in st_mode & ST_IFMT, in the
> archive's mode field, while the ustar file format only expects the
> permission bits to be there. Tar program will ignore the extra bits,
> which is why we haven't noticed, but I guess we should fix that anyway,
> for the sake of cleanliness. But that's not the root cause of the
> --append corruption.
Ok, pushed a patch to mask out the extraneous bits in the file mode
field. I only pushed it to git master, since this hasn't caused any
problems in practice.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-12-05 12:19:27 | Re: BUG #12088: pg_upgrade 9.3 -> 9.4rc1 - implicit cast not ported |
| Previous Message | Preeti Karadi | 2014-12-05 06:14:15 | Re: BUG #12141: PostgreSQL cannot be started |