| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: scram and \password |
| Date: | 2017-03-24 11:36:10 |
| Message-ID: | 5478ab75-404f-9490-9355-dc1365ce3d7f@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/23/2017 06:41 AM, Michael Paquier wrote:
> And after a lookup the failure is here:
> - result = get_role_password(port->user_name, &shadow_pass, logdetail);
> + shadow_pass = get_role_password(port->user_name, logdetail);
> if (result == STATUS_OK)
> result is never setup in this code path, so that may crash.
Ah, of course. For some reason, I has -Wno-maybe-uninitialized in my
configure command line. Without that, gcc even warns about that.
Fixed, and pushed. Thanks!
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-03-24 11:48:35 | Re: Logical replication existing data copy |
| Previous Message | Dave Page | 2017-03-24 11:35:19 | Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv |