Re: parser handling of large object OIDs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: parser handling of large object OIDs
Date: 2010-06-10 02:26:12
Message-ID: 5470.1276136772@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Jun 9, 2010 at 5:02 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I believe that the comment code is probably right, because I think
>> IConst can only handle values < 2^31, whereas OIDs can be as large as
>> 2^32-1.

> I investigated this a little more and the above analysis turns out to
> be correct. ALTER LARGE OBJECT OWNER and GRANT ... ON LARGE OBJECT
> don't work for large objects outside the range of a signed integer.

Yup.

> Session demonstrating the problem and proposed patch attached.

This patch seems extremely grotty, though. Surely that's not the way we
were doing it in the comment code?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Kirkwood 2010-06-10 02:36:13 Re: failover vs. read only queries
Previous Message Tatsuo Ishii 2010-06-10 02:07:47 Re: failover vs. read only queries