Re: psql \sf doesn't show it's SQL when ECHO_HIDDEN is on

On 11/21/2014 01:05 PM, Andrew Dunstan wrote:
>
> On 11/21/2014 12:32 PM, Tom Lane wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>> On 11/21/2014 11:11 AM, Pavel Stehule wrote:
>>>>> I noticed the other day that psql doesn't honor ECHO_HIDDEN for \sf.
>>> OK. it was so trivial I just did it.
>> I think it may not be quite as trivial as that. In particular, PSQLexec
>> already contains error-reporting functionality, so I think that the
>> minimal_error_message stuff may now be dead. You should hack things to
>> cause a query error in there and see if the reporting behavior is nice.
>>
>>
>
>
> Oh. ok.

Well, now we get things like this:

ERROR: more than one function named "abc"
LINE 1: SELECT 'abc'::pg_catalog.regproc::pg_catalog.oid

whereas minimal_error_message suppressed the second line. If we want to
preserve that older behaviour we'll have to abandon use of PSQLexec. But
it's not so complex that that would be a huge issue.

cheers

andrew