From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: Increasing test coverage of WAL redo functions |
Date: | 2014-11-19 17:04:11 |
Message-ID: | 546CCD8B.8010706@vmware.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 11/19/2014 04:54 PM, Alvaro Herrera wrote:
> Also I'm surprised that BRIN did not turn up here. At least the "page
> evacuation protocol" to obtain a new revmap page is not exercised by the
> current tests. I suppose it's because all WAL records are covered by
> other activity, and page evacuation does not emit a specialized WAL
> record. If we have the "big" test for this, maybe we can enlarge the
> table for the brin index too to ensure we cover this.
Yeah, all of BRIN's redo functions are fully covered by current
regression tests. Well done :-).
The evacuation code indeed isn't covered. That would be pretty easy to
fix; just make a table that has a brin index on it large enough.
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-11-19 17:12:22 | Re: What exactly is our CRC algorithm? |
Previous Message | Aaron W. Swenson | 2014-11-19 17:03:29 | Move Deprecated configure.in to configure.ac |